Open maximsch2 opened 7 years ago
It's in the works...
On Wed, Dec 7, 2016 at 11:05 PM, Maxim Grechkin notifications@github.com wrote:
Current version that one gets from Pkg.add is has the tests failing and pulls really old version of Optim.jl. I did Pkg.checkout to get the latest version of LowRankModels.jl and it seems to be working fine and passing all the tests. Would it make sense to tag a new version?
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/madeleineudell/LowRankModels.jl/issues/68, or mute the thread https://github.com/notifications/unsubscribe-auth/AAyp9FmSPS-xuN2y6_K2pFNfxHqt3GP0ks5rFy2hgaJpZM4LHLBl .
-- Madeleine Udell Assistant Professor, Operations Research and Information Engineering Cornell University https://people.orie.cornell.edu/mru8/ (415) 729-4115
Hey Madeleine, would you like some help with this? I can fix the current git issues and re-tag if you give me commit rights. The current state of LowRankModels is breaking the automated testing of ScikitLearn.jl
Yes, that would be great; I've been having some trouble with the package manager. Just invited you to the repo. The current master version is fine to tag.
On Mon, Jan 30, 2017 at 10:46 AM, Cédric St-Jean notifications@github.com wrote:
Hey Madeleine, would you like some help with this? I can fix the current git issues and re-tag if you give me commit rights. The current state of LowRankModels is breaking the automated testing of ScikitLearn.jl
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/madeleineudell/LowRankModels.jl/issues/68#issuecomment-276097699, or mute the thread https://github.com/notifications/unsubscribe-auth/AAyp9K6ZFLEvS3b49ZTgwni9dtLMYIsbks5rXgXEgaJpZM4LHLBl .
-- Madeleine Udell Assistant Professor, Operations Research and Information Engineering Cornell University https://people.orie.cornell.edu/mru8/ (415) 729-4115
At this point, I think that I should close the METADATA PR, and delete the tag. I can help again for the next tag (though maybe we could use attobot, it's been super-nice in my experience). But the tests should be fixed before tagging again. Maybe I'll git-bisect the failure...
Since this is importing things from DataArrays, it should depend on DataArrays directly in REQUIRE. There's also a use of FactCheck in the tests without a corresponding entry in test/REQUIRE.
Current version that one gets from
Pkg.add
is has the tests failing and pulls really old version ofOptim.jl
. I didPkg.checkout
to get the latest version of LowRankModels.jl and it seems to be working fine and passing all the tests. Would it make sense to tag a new version?Log of test errors on 0.5 based on the latest release: http://pkg.julialang.org/logs/LowRankModels_0.5.log