search

madeleineudell / LowRankModels.jl

LowRankModels.jl is a julia package for modeling and fitting generalized low rank models.
Other
190 stars 65 forks source link

WIP: Get test passing #96

Closed rofinn closed 3 years ago

rofinn commented 5 years ago

Got tests mostly passing on julia >=1.1

TODO:

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@550f8d0). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #96   +/-   ##
=========================================
  Coverage          ?   60.13%           
=========================================
  Files             ?       26           
  Lines             ?     1638           
  Branches          ?        0           
=========================================
  Hits              ?      985           
  Misses            ?      653           
  Partials          ?        0
Impacted Files Coverage Δ
src/LowRankModels.jl 100% <ø> (ø)
src/losses.jl 65.12% <ø> (ø)
src/algorithms/quad_streaming.jl 97.01% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 550f8d0...b5b47cc. Read the comment docs.

rofinn commented 5 years ago

Anyone have any tips for address the the 2 TODO items? I can probably just follow the logic for the first point (although someone more familiar with the code organization might be able to help narrow down the search). As for the second point, maybe folks have some suggestions on why the sparse implementation isn't converging to the same values?