search

madeleineudell / ParallelSparseRegression.jl

Other
12 stars 7 forks source link

Simplified the api by removing the Params object. #6

Closed ingenieroariel closed 10 years ago

ingenieroariel commented 10 years ago

This pull requests reduces the number of lines of code while simplifying the API and solving an open issue that prevented the tests from running (Fixes #4)

I hope you like the new syntax as much as I do :)

madeleineudell commented 10 years ago

That's an interesting modification. I'm going to leave it as is for now, because the same parameters apply to a number of different algorithms I'm planning to add to this package. But I agree that if admm were the only algorithm in this package, it would be better not to create a new type for the parameters.