madelson / DistributedLock

A .NET library for distributed synchronization
MIT License
1.74k stars 182 forks source link

Fix #162 RedisScript fails for the CultureInfo tr-TR (and use BacklogPolicy.FailFast for backward compatibility) #173

Closed Bartleby2718 closed 4 months ago

Bartleby2718 commented 9 months ago

Hi @madelson, here's my first PR in this repo! Looking forward to your feedback on this PR.

madelson commented 7 months ago

@Bartleby2718 do you plan to follow up on this PR?

Bartleby2718 commented 7 months ago

@ I’d like to, but unfortunately, I don’t have a good answer to your “biggest concern” in https://github.com/madelson/DistributedLock/pull/173#discussion_r1349522489.

madelson commented 4 months ago

Closing since I ended up reworking the code a quite a bit to solve for the backlog/failfast issue discussed above. The test you wrote has been integrated. Thanks @Bartleby2718 !