madelson / DistributedLock

A .NET library for distributed synchronization
MIT License
1.92k stars 198 forks source link

Upgrade npgsql (Postgres) to the very latest version #196

Closed Bartleby2718 closed 8 months ago

Bartleby2718 commented 8 months ago

Context

Per the discussion in #111, this PR upgrades Npgsql from 5.0.4 to 8.0.2, the latest version at the time of filing.

Considerations

Breaking Changes

I don't think there are breaking changes that affect DistributedLock, but please take some time to go over the breaking changes:

Usage of the Recent Versions

As you can see in https://www.nuget.org/packages/Npgsql/8.0.2#versions-body-tab, 8.0.0 has the most number of downloads, but both 8.0.1 and 8.0.2 have over a million downloads. Given that these are bug patches, I think 8.0.2 is better than the previous 8.0.* versions.

Open Questions

  1. https://github.com/madelson/DistributedLock/pull/196#discussion_r1531449283
  2. https://github.com/madelson/DistributedLock/pull/196#discussion_r1531449387
madelson commented 8 months ago

This looks good to go. By my count the only outstanding small comments are:

Bartleby2718 commented 8 months ago

Leaving a comment so @madelson can assign me.