madelson / DistributedLock

A .NET library for distributed synchronization
MIT License
1.74k stars 182 forks source link

Add build checks for AOT compat #197

Closed Bartleby2718 closed 3 months ago

Bartleby2718 commented 3 months ago

The blog post linked in #180 says:

I would still recommend using the Roslyn analyzers, which means targeting net8.0, because of the convenience and developer productivity they provide.

so I suppose we're going with the first approach of using Roslyn Analyzers?

madelson commented 3 months ago

so I suppose we're going with the first approach of using Roslyn Analyzers?

I think this is what we want for now, yes. If someone comes to us asking specifically for more trimming support in some fashion we can come back to the more in-depth approach of having a test app alongside.

madelson commented 3 months ago

@Bartleby2718 can you comment on an issue in this repo (e.g. #180)? Then I can assign things to you (in theory, see https://discuss.openedx.org/t/assigning-people-to-tickets-github-permissions/6934).

Bartleby2718 commented 3 months ago

@madelson Just did; try again?