search

madelson / MedallionShell

A .NET library simplifying the execution and chaining of processes
MIT License
415 stars 32 forks source link

[PR] The proj files have been updated to enable SourceLink #74

Closed JTOne123 closed 8 months ago

JTOne123 commented 4 years ago

CSProj files have been updated to enable SourceLink in your nuget

[This pull request was created with an automated workflow]

I noticed that your repository and Nuget package are important for our .NET community, but you still haven't enabled SourceLink.

We have to take 2 steps: 1) Please approve this pull request and make .NET a better place for .NET developers and their debugging. 2) Then just upload the .snupkg file to https://www.nuget.org/ (now you can find the snupkg file along with the .nuget file)

You can find more information about SourceLine at the following links
https://github.com/dotnet/sourcelink https://www.hanselman.com/blog/ExploringNETCoresSourceLinkSteppingIntoTheSourceCodeOfNuGetPackagesYouDontOwn.aspx

If you are interesting about this automated workflow and how it works
https://github.com/JTOne123/GitHubMassUpdater

If you notice any flaws, please comment and I will try to make fixes manually

madelson commented 4 years ago

@JTOne123 it looks like this is altering the AssemblyInformationalVersion (comes out as 1.6.1+823f2a1d097e8a41669855c5323d7763da9d3eaf). Not a huge deal, but if there is a way to preserve the simpler version that would be nice. Will this alter the nuget package version in the same way?

JTOne123 commented 4 years ago

hm, I don't know

Bartleby2718 commented 8 months ago

@madelson @JTOne123 This seems to have been superseded by https://github.com/madelson/MedallionShell/commit/e64f2f5a8c7782a7515656b9bf94bea6177e8bd7 (which is in release-1.7 but not yet in master). Should this be closed?