madenwala / Yelp.Api

C# Portable Class Library for Yelp (Fusion API v3 from 2017). Works with Windows 10, Windows 8, Windows Phone, ASP.NET, Xamarin (iOS/Android), Mac, and other .NET projects. Yelp's (v3) Fusion API allows you to get the best local business information and user reviews of over million businesses in 32 countries.
6 stars 11 forks source link

Yelp Authentication Update #7

Open ccoffey1 opened 6 years ago

ccoffey1 commented 6 years ago

Yelp removed the client secret as a means to authenticate and changed it instead to an API key. https://www.yelp.com/developers/documentation/v3/authentication#where-is-my-client-secret-going

Any plans to make this work with the new revision?

dsarlo commented 6 years ago

I have created a pull request to fix this issue. We are good to go!

gmisa commented 6 years ago

Hope this gets approved and merged soon!

shumach5 commented 6 years ago

@madenwala Hi could you take a look at pull request from @dsarlo ? seems like it works well.

dsarlo commented 6 years ago

@shumach5 I have emailed him. Hopefully he takes a look at it soon, but I'm sure he is busy with other more important things.

shumach5 commented 6 years ago

ah ok. sorry for the rush..

dsarlo commented 6 years ago

@gmisa @shumach5 @Pinski For now you guys can go to my github, clone the repo and build it with the fixes so that you can still develop your applications. Just build the dll and add it to your references in your project. When @madenwala finally checks the pull request I made in his repo, I'm sure he'll push it to nuget and github so your package will be updated in the long run. However, if he doesn't come back, I will personally upload my fork of this api onto nuget and will continuously refactor/iterate on it to keep it updated. Giving him some more time though.

dunsin99 commented 6 years ago

How exactly do I run the code/project?

Pinski commented 6 years ago

If you want to use this, the first thing you'll need to do is register as a developer with Yelp and get your API Key.

From there, it depends on what you are trying to do. If you just want to use the project in your code, it's just a NuGet package that you import just like any other dependency. Unfortunately it seems to only targets .NETPortable and the original author seems to not be updating it any more.

I've created my own fork that targets .NET Core 1.1 (hoping to add .NET Core 2.0 soon). I've also added additional functionality (like GraphQL), added an example project to show how you would use the code in your own project, and created a separate NuGet package for use. You can see more details about my fork here: https://github.com/Pinski/Yelp.Api.Web

If you are interested in pulling down the project and running it locally, then you'll just clone the repo and build it in Visual Studio.

dunsin99 commented 6 years ago

If you want to use this, the first thing you'll need to do is register as a developer with Yelp and get your API Key.

From there, it depends on what you are trying to do. If you just want to use the project in your code, it's just a NuGet package that you import just like any other dependency. Unfortunately it seems to only targets .NETPortable and the original author seems to not be updating it any more.

I've created my own fork that targets .NET Core 1.1 (hoping to add .NET Core 2.0 soon). I've also added additional functionality (like GraphQL), added an example project to show how you would use the code in your own project, and created a separate NuGet package for use. You can see more details about my fork here: https://github.com/Pinski/Yelp.Api.Web

If you are interested in pulling down the project and running it locally, then you'll just clone the repo and build it in Visual Studio.

What i meant to say is how can i verify that it is working. I have an API key and inserted it into the var but when i run my project in debug mode the result is empty.

Pinski commented 6 years ago

Could you be a little more specific and maybe show some code? Not really sure what your problem is. What's the var you are talking about? What's empty? The example code in the Readme.md file shows you exactly how to use the NuGet package.

The fork I linked to has a full working example project that you can use as reference if you need further information: https://github.com/Pinski/Yelp.Api.Web/tree/master/Source/Examples

dunsin99 commented 6 years ago

Could you be a little more specific and maybe show some code? Not really sure what your problem is. What's the var you are talking about? What's empty? The example code in the Readme.md file shows you exactly how to use the NuGet package.

The fork I linked to has a full working example project that you can use as reference if you need further information: https://github.com/Pinski/Yelp.Api.Web/tree/master/Source/Examples

Thanks for the example, I am running through it. I get a HTTP Error 502.5 - Process Failure when I build and run the example. I switched the API key for mine and still getting a similar error.

dunsin99 commented 6 years ago

Could you be a little more specific and maybe show some code? Not really sure what your problem is. What's the var you are talking about? What's empty? The example code in the Readme.md file shows you exactly how to use the NuGet package.

The fork I linked to has a full working example project that you can use as reference if you need further information: https://github.com/Pinski/Yelp.Api.Web/tree/master/Source/Examples

The nuget package for AspNetCore is 1.1.2: Is it a netcoreapp1.1 would I need to upgrade it?

dunsin99 commented 6 years ago

I migrated to 2.0 and it now works! Thank you very much