madeofpendletonwool / PinePods

Pinepods is a complete podcast management system and allows you to play, download, and keep track of podcasts you enjoy. All self hosted and enjoyed on your own server!
https://pinepods.online
GNU General Public License v3.0
187 stars 13 forks source link

Error trying to create account on try.pinepods.online. #203

Closed adamshand closed 1 month ago

adamshand commented 1 month ago
image
madeofpendletonwool commented 1 month ago

Thanks for pointing this out! I quickly glanced at it here. Seems to be an inconsistency with postgres database return types. I'll have it fixed in no time!

madeofpendletonwool commented 1 month ago

Bug should be fixed. I just created a user. Thanks again for opening it! I'll keep an eye on it to ensure it doesn't pop up again. It's caused by an inconsistency in the psycopg return typing and it makes it difficult to test because of how inconsistent it is. Most of the time there's no issue, but sometimes it seems to just return data in a totally different way.

adamshand commented 1 month ago

Sorry, but I'm still getting the same error?

It might be because I chose a username with a . in it the first two times? At least the third time when I created an account without a ., it worked.

image
madeofpendletonwool commented 1 month ago

You were right indeed, it was still due to that inconsistency. The characters were just a coincidence. That create user function calls two the database twice, I fixed it on one, the second call to the db has now also been fixed. I'll create about 10 users just to be safe and ensure they all work, but I think we're good at this point. Thanks again for opening the issue!