search

madetech / the-wolves

A timesheet reminder system.
0 stars 0 forks source link

Fix SlackGateway to filter out users and add tests to check #26

Closed dushan-madetech closed 5 years ago

dushan-madetech commented 5 years ago

What's the difference between ExcludedSlackUsersExampleResponse.json and SlackUsersExampleResponse.json?

One of them marks some of the users as deleted or restricted to get filtered out - so the expectations for the tests would be different. We didn't want to modify the existing tests so we created a new file to use in the text fixture for testing filtering

C-gyorfi commented 5 years ago

What's the difference between ExcludedSlackUsersExampleResponse.json and SlackUsersExampleResponse.json?

The difference is that the deleted property is set to true for the ExcludedSlackUsersExampleResponse.json whereas it is false in the other file.