search

madewithkoji / koji-vcc

A library that exposes VCC and ENV values for easy consumption in a Koji app
10 stars 5 forks source link

Concise and readable projectConfig modifications #3

Closed otterlistic closed 5 years ago

otterlistic commented 5 years ago

Nested if condition was removed and repetition of projectConfig[key] has been avoided. It's possible to mitigate the usage of forEach and filter on line 11 and 12 using reduce() which will be the next PR

otterlistic commented 5 years ago

The changes have been made and reduce() has also been included

sthielen commented 5 years ago

Sweet! LGTM :)