search

madewithpat / todoist-clone-web

The front end web app for the Todoist clone project
2 stars 0 forks source link

Definitely not master #5

Open kanyetehgiant opened 5 years ago

kanyetehgiant commented 5 years ago

hopefully this is right

madewithpat commented 5 years ago

Got sidetracked tonight, will take a look tomorrow @kanyetehgiant

You can click files changed underneath the PR title and make comments on specific lines. Just from a first glance, I saw a few places we can add some arrow functions to get rid of bind() calls, and we can probably get rid of some constructor functions (declaring state in a constructor is somewhat of an anti pattern, because you're mutating the component at run time; it breaks immutability)