search

madewokherd / wine-mono

Other
294 stars 39 forks source link

Skip mono runtime cleanup. #111

Closed madewokherd closed 3 years ago

madewokherd commented 3 years ago

Somehow this made the test suite take so long we didn't get any results. Also it trips the expect_no_runtimes check at process exit.

madewokherd commented 3 years ago

Searching the CI logs for "Test timed out" shows that this introduces quite a few failures to exit and thus 5 minute timeouts.

madewokherd commented 3 years ago

The problem was that we rely on profiler events to to prevent a loop of Environment.Exit -> crt exit() -> CorExitProcess -> Environment.Exit. Once shutdown has started, we just have CorExitProcess call ExitProcess, but we need the profiler event to tell us when that is. So we need that notification in the non-cleanup codepath.

madewokherd commented 3 years ago

Merged manually as https://github.com/madewokherd/wine-mono/commit/b106a8394ab21153bcd7f6b252c812bcb50fe22f