search

madewokherd / xalia

Service adding gamepad UI to traditional desktop applications
MIT License
86 stars 3 forks source link

Xalia v0.4.4 crashing inside GudlTokenizer #48

Closed BLaDZer closed 1 month ago

BLaDZer commented 1 month ago

Please help. Actually I'm getting Xalia crash in the steam, but it also reproduced in standalone version:

Unhandled exception in Xalia: System.FormatException: The input string '0.2' was not in a correct format. at System.Number.ThrowFormatException[TChar](ReadOnlySpan1 value) at System.Double.Parse(String s) at Xalia.Gudl.GudlTokenizer.<>c.<.cctor>b__6_7(<>f__AnonymousType72 <>h__TransparentIdentifier0, TextSpan dec) in D:\a\xalia\xalia\xalia\Gudl\GudlTokenizer.cs:line 60

Message looks weird to me but I cannot get what is going on. More info in the logs: system_info.log crash.log

madewokherd commented 1 month ago

I forgot CultureInfo.InvariantCulture. Sorry about that. Should be an easy fix at least.

madewokherd commented 1 month ago

Just so I can make sure I test it, what locale are you using?

madewokherd commented 1 month ago

I wasn't able to reproduce this locally (I'm probably just not overriding my locale correctly) so I just went through and added InvariantCulture anywhere I could find that might be a problem.

Could you try with the current CI build? (https://github.com/madewokherd/xalia/actions/runs/11262113557/artifacts/2036979861)

BLaDZer commented 1 month ago

Hi, thanks for the fix!

Not sure if it's working fine but at least it stop crashing now

madewokherd commented 1 month ago

Thanks, closing.