madeyourday / contao-rocksolid-slider

RockSolid Slider Contao Extension
http://rocksolidthemes.com/de/contao/plugins/responsive-slider
Other
9 stars 7 forks source link

Image meta data "alt" and "title" not displayed/used correctly #51

Closed CMSworker closed 6 years ago

CMSworker commented 6 years ago

Base: Contao 4.4 – In file manager the images used for a simple "image slider" have defined fields "title", "alt" and "link". In the slide of an "image slider" only an image is selected. I did not enter a link url inside the slide.

I found some issues when checking if the image meta data is used for the slider:

1) Why is the image description (alt tag) here used as link title? I think this should only be a fallback when the title field of the image is not filled...

https://github.com/madeyourday/contao-rocksolid-slider/blob/93aa8e3b92609a10792ad1e6e33be67d045e38b8/src/Resources/contao/templates/rsts_default.html5#L37

2) Why is the image title not used as link title for image slides? When a title is defined it should be used...

https://github.com/madeyourday/contao-rocksolid-slider/blob/93aa8e3b92609a10792ad1e6e33be67d045e38b8/src/Resources/contao/templates/rsts_default.html5#L170

3) In the html output of the image, the title text is used as alt description – that wrong/mixed up. I dind't find the line in the template code, but the result look simplified like this:

<img src="..." alt="TITLE-FIELD" ... >