search

madeyourday / contao-rocksolid-slider

RockSolid Slider Contao Extension
http://rocksolidthemes.com/de/contao/plugins/responsive-slider
Other
9 stars 7 forks source link

Row size too large - optimization for tl_module #85

Closed contaoacademy closed 1 year ago

contaoacademy commented 1 year ago

As discussed via Slack, it would be helpful if the extension's SQL queries are optimized so that the error occurs much less frequently.

similar to: https://github.com/contao/contao/commit/4cdc5035fa02f3ea8efe91617bed10cd4f460a6e

ausi commented 1 year ago

Table size was reduced quite a bit now in 17f9ad4537e817f2476984acd851611659bf9f15

Table InnoDB before InnoDB after MySQL before MySQL after
tl_content 3256 2887 26089 19715
tl_module 3638 3269 13892 7518

@contaoacademy do you have an installation where you can test this (via the dev-master version)?

contaoacademy commented 1 year ago

@ausi I don't currently have an installation that directly has a problem with the row size. However, I have an installation with the slider where I can at least check the basic functions with dev-master.

Does this help you?

ausi commented 1 year ago

Does this help you?

Yes, please 👍

contaoacademy commented 1 year ago

Ok, I will give you feedback as soon as possible.

ausi commented 1 year ago

Released in version 2.2.3

contaoacademy commented 1 year ago

@ausi Thanks for the new release and changes. I could not find any problems in my installation so far. If an error should appear, I would report.