search

madflow / flow-netbeans-markdown

Markdown file support for the NetBeans IDE
MIT License
277 stars 40 forks source link

Better icon #107

Closed josefsabl closed 6 years ago

josefsabl commented 8 years ago

I think that current icon is not very nice and looks out of place in NetBeans. In this pull request is a new icon which will look better side by side with other NB icons.

Thaks for considering this.

madflow commented 8 years ago

The icon was pull request from @rmburkhead . I believe it was taken from https://github.com/dcurtis/markdown-mark an initiative to brand markdown documents.

I personally agree that it looks out of place compared to the other (rather boring) NB icons - however - It signals pretty good where the Readme.md's are like this;).

If there is a public vote of some kind to change this - I am totally open to introduce another icon.

I am leaving this PR open for RFC.

rmburkhead commented 8 years ago

It was from a pull request from me. It was taken from https://github.com/dcurtis/markdown-mark .

I agree that it is not necessarily in sync with the other Netbeans icons, and agree...too...with @madflow 's parenthetical commentary. :) Not sure that the Markdown Mark that @dcurtis has come up with has gained universal--or even widespread--adoption.

I'm kinda partial to leaving it as is.

That said....If it were to change, I'd be more partial to taking the present Markdown Mark and superimposing it over a blank document icon border-from-the-current-icon and all, rather than losing the border from the current icon and just superimposing the M↓.

As a final note, you'll notice that GitHub is using the Markdown Mark from @dcurtis on this very site. Look closely at the icon that precedes the statement "Styling with Markdown is supported" when composing a comment or reply.