madgraph5 / madgraph4gpu

GPU development for the Madgraph5_aMC@NLO event generator software package
30 stars 32 forks source link

Add single precision builds and tests in the CI #214

Closed valassi closed 1 year ago

valassi commented 3 years ago

This is the second part of #167, which initially had this name but actually had two parts

valassi commented 3 years ago

@hageboeck you want to do this? I would start with eemumu only (wherethe above is done).

About ggtgg that requires much more work (not only porting #213, but also porting various fixes to the tests from other PRs, and possibly additional fixes in the c++/cuda), before the CI stage.

Thanks Andrea

hageboeck commented 3 years ago

I'll have a look on how to activate a build & test for eemumu. I understand that for gg, it's better to wait?

valassi commented 3 years ago

I'll have a look on how to activate a build & test for eemumu. I understand that for gg, it's better to wait?

Thanks! Yes just wait for gg*...

hageboeck commented 3 years ago
hageboeck commented 3 years ago

Reopening (github closed it), since gg* is missing.

valassi commented 2 years ago

Reviewing old issues... @hageboeck I am tempted to close this. I think the real need was to have AT LEAST ONE float build for both c++ and cuda in the CI. I am not sure we need to have every single process there (and even, we are testing epochX cudacpp there, it would instead be interestung to add at least one sycl/kokkos/alpaka eventually).

This is to say: I do not think we also need ggtt and ggttgg float from epochX/cudacpp in the CI. But then, as you prefer.

Thanks! Andrea

hageboeck commented 2 years ago

Less CI jobs are of course better as long as we cover all code paths. 👍

valassi commented 1 year ago

Hi @hageboeck thanks again for this. I am closing this. In the meantime we have also added mixed precision to the CI (see #580, #581, MR #582).

This can beclosed.