madgraph5 / madgraph4gpu

GPU development for the Madgraph5_aMC@NLO event generator software package
30 stars 33 forks source link

NOT TO BE MERGED - ("jthip24") Jorgen's earlier work on HIP before PR #774 and my fixes on that #800

Closed valassi closed 7 months ago

valassi commented 7 months ago

This is a temporary PR that I file here only for reference and to keep the relevant code. I will close it immediately after creating it.

This PR uses my "jthip24" branch, which is itself an addition over Jorgen's branch https://github.com/Jooorgen/madgraph4gpu/tree/gpu_abstraction Jorgen's "gpu_abstraction" includes HIP work but also CI/profiling work by Jorgen. My "jthip24" branch includes the above, with the addition of some extra fixes which I was working on together with Jorgen in July-August (and some more recent ones).

Jorgen's "gpu_abstraction" branch never made it into a PR. Instead, Jorgen stripped off a smaller/different "gpu_abstraction_only" branch which he used to open PR #774. https://github.com/Jooorgen/madgraph4gpu/tree/gpu_abstraction_only

When I tried to work over PR #774, I had several issues from "gpu_abstraction_only", which I had already fixed with Jorgen in this "gpu_abstraction". Therefore I had to go back and forth between the two branches to compare and pick up the better code. This is in my "jt774" branch which I will use for an upcoming PR.

I file this PR (which I will immediately close) for two reasons

Note that I have merged jt774 into this jthip24, so now the two lines of developmente have converged again, just in case.

Note also that Jorgen's "gpu_abstraction" is now what he used for PR #718, which instead is based on his master.

valassi commented 7 months ago

As discussed, I am closing this immediately.