search

madgraph5 / madgraph4gpu

GPU development for the Madgraph5_aMC@NLO event generator software package
29 stars 33 forks source link

channelIDs #830

Closed roiser closed 1 month ago

roiser commented 4 months ago

Hi @oliviermattelaer this is the PR for the channelIds, this goes together with the mg5amcnlo:gpucpp_wrap branch. Functionality wise this should be it now. I still mark it as WIP as not all processes have been re-generated and also the comparison of the generated code fails because of some missing spaces here and there. cc @valassi

roiser commented 1 month ago

Dear @oliviermattelaer many thanks for your help with the pkl file, now all tests are green, I suppose we can review this PR at your convenience. cheers

oliviermattelaer commented 1 month ago

Hi,

I have looked at the code and this is good to go. But I have changed the target to master_june24 (as discussed) and as expected they are now a (non super trivial) conflict that we have to fix before being able to do the merge. (and we will fix such conflict tommorow morning)

Good job,

Olivier