madgraph5 / madgraph4gpu

GPU development for the Madgraph5_aMC@NLO event generator software package
30 stars 33 forks source link

Permille cross section discrepancy fortran vs cudacpp (gg_tt.mad) after merging june24 and goodhel together #991

Closed valassi closed 2 days ago

valassi commented 2 weeks ago

VERY BAD. There is a NEW permille cross section discrepancy fortran vs cudacpp after merging june24 and goodhel together.

This is still WIP, but anyway it does not look good.

Note:

valassi commented 2 weeks ago

I vaguely wonder if this is related to https://github.com/mg5amcnlo/mg5amcnlo/pull/120

I had tried to generated code with that 120, and there was only a few lines changing inggtt.mad, but this included some initializations. Maybe the initializations are missing and this will fix it? (HOWEVER june24 tests by themselves were all ok, so this sounds far fetched).

oliviermattelaer commented 1 week ago

Can you check at commit https://github.com/madgraph5/madgraph4gpu/pull/992/commits/7d0a553afb140a20173527a2d1537ba397d2e3d3

This was part of the master_goodhel but seems lost in the merging with june24 or something like that. This part of this branch: master_for360 (which is only two commit in top of your goodhel branch) and the CI are all green in that case.

If you agree, can you close this thread?

valassi commented 1 week ago

Can you check at commit 7d0a553

This was part of the master_goodhel but seems lost in the merging with june24 or something like that. This part of this branch: master_for360 (which is only two commit in top of your goodhel branch) and the CI are all green in that case.

Hi Olivier thanks, I will check, no time to do it now sorry, might have to wait next week. (I thought I had seen that comments out, but maybe it was a different branch).

If you agree, can you close this thread?

Let me test until it's fixed and then I will close it.

Just to mention (for myself mainly?) a few things I noticed yesterday, before I leave and forget:

(Rephrasing the last point, as usual clearly identifying the inputs and outputs of madevent executables is often challenging, and this is essential to these sorts of tests: equal inputs must give equal outputs, but if there are hidden inputs/outputs, it's complex)

valassi commented 2 days ago

Can you check at commit 7d0a553

This was part of the master_goodhel but seems lost in the merging with june24 or something like that. This part of this branch: master_for360 (which is only two commit in top of your goodhel branch) and the CI are all green in that case.

If you agree, can you close this thread?

Hi @oliviermattelaer I finally checked that this issues is fixed in your #992. I assume that it was indeed fixed by your commit https://github.com/madgraph5/madgraph4gpu/pull/992/commits/7d0a553afb140a20173527a2d1537ba397d2e3d3

I am closing this as fixed. Thanks!