search

madhabkirank / google-api-adwords-php

Automatically exported from code.google.com/p/google-api-adwords-php
0 stars 0 forks source link

Report download fails when clientCustomerId value used #43

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
Which version of the library are you using? aw_api_php_lib_2.2.0

Which version of PHP are you using? 5.3.1

What steps will reproduce the problem? test report download with live details

What is the expected output? What do you see instead?
Expected: Report with definition id '%s' was downloaded to '%s'
Actual: !!!1|||21285655|||AuthenticationError.CLIENT_EMAIL_INVALID???Report 
with definition id '21285655' was downloaded to 'Repor
t.xml'.

Please provide any additional information below.

line 64 needs to be: if (strpos($clientId, '@') !== false) {

Original issue reported on code.google.com by asimlq...@gmail.com on 15 Sep 2010 at 2:50

GoogleCodeExporter commented 8 years ago 
Sorry forgot to mention the file. :)

aw_api_php_lib_2.2.0/src/Google/Api/Ads/AdWords/Util/ReportUtils.php

Original comment by asimlq...@gmail.com on 15 Sep 2010 at 2:57

GoogleCodeExporter commented 8 years ago 
Good catch.  I assume this is only a problem when a clientCustomerId value is 
used?  This will be fixed for the next release.

Original comment by api.ekol...@gmail.com on 15 Sep 2010 at 5:42

GoogleCodeExporter commented 8 years ago 
That's correct.

When clientCustomerId is supplied strpos returns false and "false == 0" is 
true, hence the else will never be reached regardless of whether clientId has 
an "@" or not.

Original comment by asimlq...@gmail.com on 15 Sep 2010 at 7:09

GoogleCodeExporter commented 8 years ago 
This was fixed in r94, and is in the 2.3.0 release.

Original comment by api.ekol...@gmail.com on 15 Sep 2010 at 9:28