search

madhabkirank / google-api-adwords-php

Automatically exported from code.google.com/p/google-api-adwords-php
0 stars 0 forks source link

adx examples broken in r197 in Subversion #64

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago 
r197 in Subversion for the PHP adx samples replaced the various separate 
GetXXXService wrapper calls with direct calls to GetService.

That would have been a great idea if GetService were not a private method that 
can't be called from outside the AdWordsUser class.

Original issue reported on code.google.com by tim.the....@gmail.com on 15 Aug 2011 at 8:53

GoogleCodeExporter commented 8 years ago 
GetService() change was made in r194, and the function was made public at the 
same time that the examples were changed.

http://code.google.com/p/google-api-adwords-php/source/browse/trunk/src/Google/A
pi/Ads/AdWords/Lib/AdWordsUser.php?r=194#154

Please ensure you download a new version of the library in addition to the 
examples.

Original comment by ekoleda+devrel@googlers.com on 15 Aug 2011 at 9:26

GoogleCodeExporter commented 8 years ago 
I just downloaded the php client library.  The method in question is still set 
to private. Copying the code from the 
http://code.google.com/p/google-api-adwords-php/source/browse/trunk/src/Google/A
pi/Ads/AdWords/Lib/AdWordsUser.php?r=194#154 worked fine

Original comment by PRBo...@gmail.com on 26 Sep 2011 at 7:36

GoogleCodeExporter commented 8 years ago 
It looks like those revisions were never bundled into a download, hence the 
confusion.  I'll cut a new release that has all these changes in them.

Original comment by ekoleda+devrel@googlers.com on 26 Sep 2011 at 10:31

GoogleCodeExporter commented 8 years ago 
I've released version 2.6.4 which has the changes applied.

Original comment by ekoleda+devrel@googlers.com on 27 Sep 2011 at 6:05