search

madhanse / pe

0 stars 0 forks source link

Application exits due to ArrayIndexOutOfBoundsException if the CSV file is tampered #4

Open madhanse opened 2 years ago

madhanse commented 2 years ago

Picture4.png

The program doesn't continue running or clears the invalid data after tampering with the CSV file. This is very important because the user may not be able to use the application when he/she tries to execute it. It would be solved by clearing the contents and printing a warning message into the console.

Picture5.png

nus-pe-bot commented 2 years ago

Team's Response

image.png

Rejected. We have mentioned in our UG to refrain from tampering with csv directly as this is a purely CLI application.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I understand that you have given a warning message in the UG that the program will terminate when invalid data exists after the user tampers the data. But the main problem here is that the exception is not handled. Based on the image in your response, I suggest that you could have handled the exception by printing the message into the console, asking the user to make some changes so that the data is valid before running the program. And once the message is printed, you can exit the program.