search

madhephaestus / ESP32Servo

Arduino-compatible servo library for the ESP32
133 stars 53 forks source link

Updated ESP32PWM.cpp to avoid checks on old ledAttachPin function #59

Closed CrazyLegoMind closed 2 months ago

CrazyLegoMind commented 2 months ago

the old ledcAttachPin is a void function not able to return succes boolean, this makes the library crash when compiling with ESP_ARDUINO_VERSION < 3.0.0, this changes fixes issue #58, tested and compiled succesfully for my dev esp32c3 board with ESP_ARDUINO_VERSION = 2.0.9

abstractBoyd commented 2 months ago

Nice, thanks for submitting the MR! I was planning on jumping on it tonight if no one else got around to it :)

madhephaestus commented 2 months ago

Great thanks!