Fixed bug of using wrong pin for detach in setup() + another bug + improvement

madhephaestus / ESP32Servo

Arduino-compatible servo library for the ESP32

139 stars 55 forks source link

Fixed bug of using wrong pin for detach in setup() + another bug + improvement #66

Open ArminJo opened 1 month ago

ArminJo commented 1 month ago

Improved ESP_ARDUINO_VERSION handling.
Fixed bug of using wrong pin for detach in setup().
Fixed bug of calling ledcAttach() twice for same pin.

Without this fixed I got: [ 7634][E][esp32-hal-periman.c:180] perimanGetPinBus(): Invalid pin: 255 [ 7641][E][esp32-hal-periman.c:122] perimanSetPinBus(): Invalid pin: 255 [ 7647][E][esp32-hal-ledc.c:116] ledcAttachChannel(): Pin 255 is already attached to another bus and failed to detach

ArminJo commented 6 days ago

Hi, any remaining concerns that prevent you from merging this PR?