Sets up bcrypt - Githubissues

madhums / node-express-mongoose-demo

A simple demo app using node and mongodb for beginners (with docker)

https://nodejs-express-demo.fly.dev

MIT License

5.12k stars 1.38k forks source link

Sets up bcrypt #357

Closed Raywire closed 4 years ago

Raywire commented 5 years ago

What does this PR do?

Sets the app to use bcrypt.

Description of Task to be completed?

[x] Adds the bcrypt dependency
[x] Updates authenticate method to use bcrypt
[x] Updates encryptPassword method to use bcrypt
[x] Removes salt field from the UserSchema
[x] Removes makeSalt method

How should this be manually tested?

Clone this repo https://github.com/madhums/node-express-mongoose-demo.git
Navigate to the node-express-mongoose-demo folder cd node-express-mongoose-demo
git checkout hotfix/use-bcrypt
Run the commands below to install packages and run the server
- npm install
- npm start
Try to sign up to the app using your email address(not social auth) http://localhost:3000/signup
Log out and try to log in again, everything should work as expected.

What is the relevant issue number?

madhums commented 4 years ago

Thanks a bunch @Raywire!