search

madhums / node-notifier

A simple node.js module to handle all the application level notifications (apple push notifications and mails)
MIT License
86 stars 12 forks source link

Sending is disabled in dev or test #3

Open danielkhan opened 10 years ago

danielkhan commented 10 years ago

Hello,

thank you for creating this module.

Inside notifier.js you write: // as you don't want to send emails while development or testing and then you disable sending for NODE_ENV = test or development.

I think it isn't a good idea to disable sending in development mode and if you do so you should mention this in big red letters inside the docs as people like me spend hours to figure out why no e-mails arive.

I would suggest adding a dry-run config option and default it to true. So people can decide.

madhums commented 10 years ago

sorry for this. will add a config option

pft commented 8 years ago

Added this config option in 9b9e81d67c9e4a4dc84b0836ca20c6d2bb4f347f