Closed GoogleCodeExporter closed 9 years ago
Hi RCT,
Thanks for your patch, but it breaks some core PPSS functionality. You are
using mkdir -p. However, the mkdir command is used to make locking atomic.
using -p the locking is no longer atomic. This solution is thus not working.
I do think that the actual lock file should be an MD5 hash, only the log file
should be a regular file name if people want this.
In what kind of situation are you running into the 256 character limit?
Original comment by Louwrentius
on 29 Jan 2012 at 10:01
My usage of ppss is generating a large number of shell commands and piping them
into "ppss -M -c 'sh -c ' -f -". The commands are frequently longer than 256
characters.
Original comment by r...@thompsonclan.org
on 29 Jan 2012 at 10:22
The solution to this is not patching PPSS but to create a small script.
I guess you are creating a list of commands that are exected by sh. However,
you should not do that.
Create a list of unique items to be processed. Create a script that contains
the command executed and that expects the item as an argument. Then your
problem is solved.
If you can generate a lot of shell commands, you can probably also generate a
list of unique items to be processed.
Original comment by Louwrentius
on 30 Jan 2012 at 12:50
Please note that the explanation as described is also documented in the wiki.
Original comment by Louwrentius
on 30 Jan 2012 at 12:50
Original comment by Louwrentius
on 9 Feb 2012 at 7:49
If anything, it might be prudent to eventually implement a check for the
maximum supported file name length by progressively attempting to create longer
and longer file names until one fails. Then, check if any of the inputs are
longer than that and raise an error. Because as it works now, it just fails
silently. But this would be low priority.
An even cheaper short-term stopgap would be to just warn if any input is 256
characters or longer.
Original comment by r...@thompsonclan.org
on 9 Feb 2012 at 9:18
Original issue reported on code.google.com by
r...@thompsonclan.org
on 19 Jan 2012 at 6:48Attachments: