Open GoogleCodeExporter opened 9 years ago
Thank you - I'll try to review and update PPSS as soon as possible.
Original comment by Louwrentius
on 12 Mar 2012 at 9:39
If I'm correct, the unique name (a string) of the file is hashed, not the file
itself so multiple gig files should not be an issue whatsoever. Do you agree?
Original comment by Louwrentius
on 12 Mar 2012 at 9:41
You're right. The code says "echo", my brain says "cat". This is just a hash
of the pathname which shouldn't be too terribly CPU-intensive. :-)
Original comment by sbo...@gmail.com
on 12 Mar 2012 at 10:07
In SVN, I have a ppss-test.sh suite, run it with ./ppss-test.sh debug to get
the actuall output results.
It shows that the NoRecursion tests fails.
Your version does not pick up some files somehow.
Wrong:
{{{
/tmp/ppss/root/file-1
/tmp/ppss/root/file-10
/tmp/ppss/root/file-2
/tmp/ppss/root/file-3
/tmp/ppss/root/file-4
/tmp/ppss/root/file-5
/tmp/ppss/root/file-6
/tmp/ppss/root/file-7
/tmp/ppss/root/file-8
/tmp/ppss/root/file-9
}}}
Correct:
{{{
/tmp/ppss/root//file-1
/tmp/ppss/root//file-10
/tmp/ppss/root//file-2
/tmp/ppss/root//file-3
/tmp/ppss/root//file-4
/tmp/ppss/root//file-5
/tmp/ppss/root//file-6
/tmp/ppss/root//file-7
/tmp/ppss/root//file-8
/tmp/ppss/root//file-9
/tmp/ppss/root//hosts
/tmp/ppss/root//resolve.conf
}}}
I do not understand why this is the case and I don't have Solaris anywhere
around here.
Original comment by Louwrentius
on 17 Mar 2012 at 8:34
It looks like SVN is missing the "shunit2" script called by the test. Is that
intentional? I'm also not sure where the assertEquals function is defined.
The problem with the find is that it looks like the skipped items are symlinks.
The Solaris-compatible find command would include a symlink to a directory as
a file to process, so it's only looking for files of "-type f".
The original -maxdepth 1 command also does this, so to simulate the original
output just change the lines like:
$(exec_cmd "find \"$SRC_DIR\" ( ! -name \"$_dir_basename\" -o -type f ) -prune
-type f -print" > "$LISTOFITEMS")
to (change the final "-type f" to "! -type d"):
$(exec_cmd "find \"$SRC_DIR\" ( ! -name \"$_dir_basename\" -o -type f ) -prune
! -type d -print" > "$LISTOFITEMS")
Of course, you may not want to include symlinks to directories as files to
process. :-)
Original comment by sbo...@gmail.com
on 18 Mar 2012 at 5:27
Ah right, I look into this. thanks.
Original comment by Louwrentius
on 20 Mar 2012 at 1:54
I incorporated the proposed fixes in SVN. I also included shunit2 for
convenience. I tested your solution and it worked on Mac OS X Lion again. After
that, I added if-statements to only use this trick if Solaris is detected. Not
all that clean, but I can live with that. If there are any issues, I'd like to
know. Thanx!
Original comment by Louwrentius
on 24 Mar 2012 at 9:15
Original issue reported on code.google.com by
sbo...@gmail.com
on 10 Mar 2012 at 5:07Attachments: