madhuneal / ppss

Automatically exported from code.google.com/p/ppss
0 stars 0 forks source link

Constructing log file names based on item name should validate input - was: Fails when items are not in the current directory #7

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. ls ../DATA/*.flm > flm.files
2. ppss.sh -c ./do-flm2data.sh -f flm.files

What is the expected output? What do you see instead?
Apparently it fails doing:
        EXECME='$COMMAND"$ITEM" > "$JOB_LOG_DIR/$ITEM"'
        eval "$EXECME"

Output:
/nfshomes/den/bin/ppss.sh: line 550:
job_log/../DATA/3TB_hyphen_normalized_par.flm: No such file or directory

What version of the product are you using? On what operating system?
1.05, Linux

Please provide any additional information below.

Original issue reported on code.google.com by denk.jun...@gmail.com on 10 Jan 2009 at 10:14

GoogleCodeExporter commented 9 years ago
I see the problem. Output for each item is redirected to a log file that is 
based on the name of the item.

If the item is named like "../DATA/3TB_hyphen_normalized_par.flm" this 
obviously fails. So in order to construct 
a file name for logging, all slashes and probably dots must be stripped from 
the input. 

Original comment by Louwrentius on 11 Jan 2009 at 9:12

GoogleCodeExporter commented 9 years ago

Original comment by Louwrentius on 11 Jan 2009 at 9:14

GoogleCodeExporter commented 9 years ago

Original comment by Louwrentius on 11 Jan 2009 at 10:01

GoogleCodeExporter commented 9 years ago
Regarding the file path of items: you must specify the path also within the -c 
command and it willl work. 

Original comment by Louwrentius on 12 Jan 2009 at 7:01

GoogleCodeExporter commented 9 years ago

Original comment by Louwrentius on 8 Mar 2009 at 3:34