Index out of bounds error[BUG]

emmagoodrich commented 1 year ago

Tasks

[X] I have carefully followed the instructions in the README.
[X] I have read through the page Known bugs and limitations, and my bug is not described there.
[X] I have searched for my issue on the Issues page and did not find it there.
[X] The issue I am raising is a potential bug and not just a usage question. For a usage question, please go back in your browser and select the Question option.

Description

Asked to report by Montek - getting Index Out of Bounds error when trying to load .json file

Reproduction steps

Go to terminal
run 'mips-em' (not sure if you want my .mem files)

Expected behavior

Emulator to start running. I did not change anything in the .json file, and all my .mem file names match what is in the file.

Screenshots

No response

Logs

No response

OS

macOS

Additional context

No response

jesse-wei commented 1 year ago

Please paste your JSON file here, I'll check it out

jesse-wei commented 1 year ago

Are you using 32x32 (i.e., not 16x16) sprites? Sprites that aren't 16x16 aren't supported.

The exception that occurs is in VGADisplayBMPController, which controls the screen, and the error you're getting is related to the screen.

Specifically, I'm seeing "index 300 out of bounds for size 300", and 300 px is the height of the VGA display. Your code should only be attempting to access index 299 at most but is attempting to access 300, for some reason.

Since execution didn't get past the initialize method, it might be your smem file. How many lines are in each of your mem files?

jesse-wei commented 1 year ago

Emma is using 32x32 sprites, which is not supported.

madiali / mips-emulator