search

madiele / vod2pod-rss

Vod2Pod-RSS converts a YouTube or Twitch channel into a podcast with ease. It creates a podcast RSS that can be listened to directly inside any podcast client. VODs are transcoded to MP3 on the fly and no server storage is needed!
MIT License
207 stars 6 forks source link

Redis Warning Memory Overcommit Must Be Enabled #196

Open kanjieater opened 1 month ago

kanjieater commented 1 month ago

app version: X.X.X

issue description: Do to the redis requirement, the application requires some external permissions that for WSL users, is only temporary. Would it be possible to use anything in alternative to redis, for instance, mounting /tmp/ that way it's still in memory and fast, without having a large external dependency?

https://stackoverflow.com/questions/76830848/redis-warning-memory-overcommit-must-be-enabled


2024-07-26 22:27:35 vod2pod-redis-1    | 1:C 27 Jul 2024 03:27:35.561 # oO0OoO0OoO0Oo Redis is starting oO0OoO0OoO0Oo
2024-07-26 22:27:35 vod2pod-redis-1    | 1:C 27 Jul 2024 03:27:35.561 # Redis version=6.2.14, bits=64, commit=00000000, modified=0, pid=1, just started
2024-07-26 22:27:35 vod2pod-redis-1    | 1:C 27 Jul 2024 03:27:35.561 # Configuration loaded
2024-07-26 22:27:35 vod2pod-redis-1    | 1:M 27 Jul 2024 03:27:35.563 # Server initialized
2024-07-26 22:27:35 vod2pod-redis-1    | 1:M 27 Jul 2024 03:27:35.563 # WARNING Memory overcommit must be enabled! Without it, a background save or replication may fail under low memory condition. Being disabled, it can can also cause failures without low memory condition, see https://github.com/jemalloc/jemalloc/issues/1328. To fix this issue add 'vm.overcommit_memory = 1' to /etc/sysctl.conf and then reboot or run the command 'sysctl vm.overcommit_memory=1' for this to take effect.
2024-07-26 22:27:36 vod2pod-vod2pod-1  | 2024-07-27T03:27:36.099Z INFO  [app] app version 1.2.1
2024-07-26 22:27:36 vod2pod-vod2pod-1  | 2024-07-27T03:27:36.101Z INFO  [app] listening on http://0.0.0.0:8080
2024-07-26 22:27:36 vod2pod-vod2pod-1  | 2024-07-27T03:27:36.103Z INFO  [actix_server::builder] starting 32 workers
2024-07-26 22:27:36 vod2pod-vod2pod-1  | 2024-07-27T03:27:36.103Z INFO  [actix_server::server] Actix runtime found; starting in Actix runtime
madiele commented 1 month ago

The cache is a key component of vod2pod since without it you would be hitting the rate limit of the API pretty soon, as for your problem that is just a warning redis should work fine in wsl even if you don't fix it (I actually use redis in wsl all the time at work), while it's not optimal you should be fine, have you found that vod2pod is not working at all in wsl?

As for using disk, the library I use does support a disk=true option for cache, but I do not know how it works to have both configuration active, if you know how to program a little try reading the contributing.md and test it, feel free to open a pr about it if you find it works, I doubt I will find the time to experiment with it soon