madina0801 / joblique

Keep track of your job applications 💼
https://joblique.onrender.com/
MIT License
5 stars 14 forks source link

fix: Change the position of the footer to fixed and add a bottom valu… #19

Closed Erick559 closed 8 months ago

Erick559 commented 8 months ago

Changed the position value to fixed and also added a bottom value of 0 to ensure the footer is always in the view port.

madina0801 commented 8 months ago

Hi, thank you for your efforts~ We need to see it only when we scrolled down to the end of the content~ Cause now on Home page it's seen even when we didn't scroll to the bottom. Will you do it?

Erick559 commented 8 months ago

okay no problem at all.

Erick559 commented 8 months ago

I refactored it once more hope that was the final look you are going for.

madina0801 commented 8 months ago

Can you add the "main" class to About component? It will make sections more consistent and solve the issue. It needs to look like this:

function About () {
  return (
      <div className="main">
        <h2>About</h2>
        <p>JobTrackr is created to keep track of your job applications. Made with love. &#x1F497;</p>
      </div>
  );
};
export default About;
Erick559 commented 8 months ago

okay i get what you are trying to achieve. My apologies I didn't look at the about page to notice that the footer wasn't at the bottom. Let me come up with a solution asap.

Erick559 commented 8 months ago

Hi I think i was able to fix the issue. The footer is now at the bottom of the page and once you start adding content to the point it starts scrolling it will still remain at the bottom. I just added a classname to the app component which allowed me to style it adding flexbox then auto margined the footer to the bottom of the screen.

madina0801 commented 8 months ago

Looks good! Thank you~

Erick559 commented 8 months ago

You're welcome🫡