madisonwong210 / Flix

0 stars 0 forks source link

Project Feedback! #1

Open codepathreview opened 4 years ago

codepathreview commented 4 years ago

šŸ‘ Nice work! The point of this homework was to get a chance to implement a TableView (one of the most common views in iOS) and to work with real data over the network (in this case from the Movies Database API).

A key part of these projects is that you add additional features and tweak the UI / UX because that will provide the most learning opportunities. We encourage you to complete the projects early each week with the required stories and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.

We have a detailed Assignment 1 Feedback Guide which covers the best practices for implementing this assignment. Read through the feedback guide point-by-point to determine ways you might be able to improve your submission. You should consider going back and implementing these improvements as well. Keep in mind that one of the most important parts of iOS development is learning the correct patterns and conventions.

Check out the assignment grading page for a breakdown of how submissions are scored.

If you have any technical questions about the project or concepts covered this week, post a question on our Discussions Forum and mark the question as type, "Curiosity". For general questions email us at, support@codepath.org.

codepathreview commented 4 years ago

Looks like your README is incomplete for this assignment šŸ˜¬. The README helps us to make sure we don't miss any required or optional stories you have completed.

Make sure all you have completed the following steps to completing your README:

  1. Make sure you have the correct README for this assignment, go to the "Submitting your App Assignment" section in the Assignment Tab for the corresponding unit in the course portal.
  2. Please mark of all completed user stories with an [x]
  3. Add a link to your animated gif walkthough to your README and make sure it renders (animates) when viewing the README.

Once completed, please push your updates and submit your assignment again so we can regrade it.

Still confused about how to properly submit your assignment? Check out the Submitting Coursework for detailed instructions.

Whenever you make updates to your project that require re-grading, you need to re-submit your project using the submit button on the associated assignment page in the course portal. This will flag your project as ā€œupdatedā€ on our end and we know to re-grade.

You should re-submit your assignment anytime you:

madisonwong210 commented 4 years ago

Hello!

Unfortunately I ran into a lot of issues with this assignment. As stated in my README, originally my app would crash whenever I clicked on the Superhero tab and I got the error message ā€œThread 1: Fatal error: Unexpectedly found nil while unwrapping an Optional valueā€. I rewatched the tutorial videos multiple times to try and figure out where I went wrong, but that didnā€™t work, so I tried to Google my issues and check the discussion posts.

Eventually, I did end up fixing the error and my app let me click on the superhero tab, but rather than showing me full images of the different movie posters, I kept getting small boxes as shown below. I tried my best to do what I could to fix that issue, but ultimately could not figure it out, so I just submitted whatever I had. As a result, Iā€™m not too sure what to do now or what Iā€™m expected to resubmit, as Iā€™m in the midst of final exams and do not have more time to spend trying to debug.

Thanks for your time, Madison

[A screenshot of a cell phone Description automatically generated]

From: CodePath Reviewers notifications@github.com Reply-To: madisonwong210/Flix reply@reply.github.com Date: Tuesday, April 21, 2020 at 2:25 PM To: madisonwong210/Flix Flix@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [madisonwong210/Flix] Project Feedback! (#1)

Looks like your README is incomplete for this assignment šŸ˜¬. The README helps us to make sure we don't miss any required or optional stories you have completed.

Make sure all you have completed the following steps to completing your README:

  1. Make sure you have the correct README for this assignment, go to the "Submitting your App Assignment" section in the Assignment Tab for the corresponding unit in the course portalhttps://courses.codepath.org.
  2. Please mark of all completed user stories with an [x]
  3. Add a link to your animated gif walkthough to your README and make sure it renders (animates) when viewing the README.

Once completed, please push your updates and submit your assignment again so we can regrade it.

Still confused about how to properly submit your assignment? Check out the Submitting Courseworkhttps://courses.codepath.org/snippets/ios_university/submitting_coursework.md for detailed instructions.

Whenever you make updates to your project that require re-grading, you need to re-submit your project using the submit button on the associated assignment page in the course portal. This will flag your project as ā€œupdatedā€ on our end and we know to re-grade.

You should re-submit your assignment anytime you:

ā€” You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/madisonwong210/Flix/issues/1#issuecomment-617422464, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AOBQOWVZNRVI5NVANR6DUQDRNYFMJANCNFSM4MKNDUAA.