search

madlabsinc / mevn-cli

Light speed setup for MEVN(Mongo Express Vue Node) Apps
https://mevn.surge.sh
MIT License
825 stars 152 forks source link

feat: install prompts and refactor init.js #161

Closed aquibbaig closed 4 years ago

aquibbaig commented 4 years ago

What kind of change does this PR introduce?

Did you add tests for your changes? Not yet

If relevant, did you update the documentation? No

Fixes #156

aquibbaig commented 4 years ago

That old commit was disordered to track, review and make changes, so made a new one instead.

aquibbaig commented 4 years ago

@jamesgeorge007 We would most likely squash all the commits before merge!

aquibbaig commented 4 years ago

@jamesgeorge007 Feel free to drop a review and resolve the conflicts. I do not have write access to do so probably or do I?

aquibbaig commented 4 years ago

Have to redo the changes here, I mistook the default branch to be master, have to make these changes on top of develop. Is that right @jamesgeorge007 ?

jamesgeorge007 commented 4 years ago

Exactly.

On Thu, 6 Feb, 2020, 12:49 AM Aquib Baig, notifications@github.com wrote:

Have to redo the changes here, I mistook the default branch to be master, have to make these changes on top of develop. Is that right @jamesgeorge007 https://github.com/jamesgeorge007 ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/madlabsinc/mevn-cli/pull/161?email_source=notifications&email_token=AGA3WH5TVJLU63XPAF5RVMDRBMGK5A5CNFSM4KPTUHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEK4UMTA#issuecomment-582567500, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGA3WH3D5PUYNTKNP422SUTRBMGK5ANCNFSM4KPTUHAA .

aquibbaig commented 4 years ago

@jamesgeorge007 I updated the branch on top of develop. There seems to be some issues with package-lock.json. Can you delete the file and do a fresh npm install.