feat: use the inhouse solution to open up default browser

madlabsinc / mevn-cli

Light speed setup for MEVN(Mongo Express Vue Node) Apps

https://mevn.surge.sh

MIT License

825 stars 152 forks source link

feat: use the inhouse solution to open up default browser #165

Closed pksjce closed 4 years ago

pksjce commented 4 years ago

What kind of change does this PR introduce? Use vue-cli-service's --open. Pass port from launch.js . Use port 3002. Update execa to latest. Convert .shell() to option {shell:true}

Did you add tests for your changes? Would love some guidance with this.

If relevant, did you update the documentation? Doesn't change external api

Summary

Fixes #164 and #142

Does this PR introduce a breaking change? No Other information

ghost commented 4 years ago

There were the following issues with this Pull Request

Commit: d31d904dfa7d3cbfe331ca0b00f84ba890b8bd7c
- ✖ body must have leading blank line

You may need to change the commit messages to comply with the repository contributing guidelines.

🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

ajomadlabs commented 4 years ago

@pksjce can you try pushing the code again

pksjce commented 4 years ago

Sorry, this is not a good time for me to be getting involved in a new project. Thanks for your patience. Closing this PR. Feel free to make necessary changes as you please.