search

madlambda / nash

Nash stands for Nash shell.
Apache License 2.0
157 stars 11 forks source link

go-get doesn't put version info #117

Open i4ki opened 8 years ago

i4ki commented 8 years ago

Some people only go-get the project, but this way "nash -version" prints nothing. The version info is injected by linker in the makefile, and only put the current branch. To create a release binary, first one need to create a tag to the release and then build nash on this tag. I don't know if it's a good idea anymore..

katcipis commented 8 years ago

I'm not sure of clever ways to get pass this, I just agree that this is not actually a problem. You will only get a clean version if you downloaded a versioned release (when we have them :P), if you go get it...well.. you got the master and there is no guarantees about versions. In internal services, you could always inject the commit id to help debugging, but on a case of a tool like nash, a plain old boring release model seems to be enough :-)

i4ki commented 8 years ago

:)

katcipis commented 7 years ago

Ok, now I had some problems that this could help, I was clearly being an idiot :-)

Perhaps we could add a tag version, and when it is from the master we use the latest commit id ? For debugging it would help a lot and it does not seem like a lot of problems.