search

madleech / ArduinoCMRI

Arduino library for connecting your computer to your model railroad.
27 stars 18 forks source link

Out of bound checking leads to buffer overflow #10

Open jlbirccyn opened 4 years ago

jlbirccyn commented 4 years ago

Hi Michael

At lines https://github.com/madleech/ArduinoCMRI/blob/master/CMRI.cpp#L107, https://github.com/madleech/ArduinoCMRI/blob/master/CMRI.cpp#L115, https://github.com/madleech/ArduinoCMRI/blob/master/CMRI.cpp#L130, test should be >= to prevent out of bound access of the array.

Best regards

Erik84750 commented 2 years ago

There seems to be no response, a pity. Thank you for that correction, I modified manually. Erik