Regression ? (re-issue #3)

[pickupapenguin]

Hi,

In a previous issue, you swiftly updated the code when this issue was reported, however the code appears to have regressed ?

cc -O3 -Wall -Wextra -c -o pigz.o pigz.c pigz.c: In function ‘copymeta’: pigz.c:3051:5: warning: ignoring return value of ‘chown’, declared with attribute warn_unused_result [-Wunused-result] pigz.c: In function ‘compress_thread’: pigz.c:1118:21: warning: ‘temp’ may be used uninitialized in this function [-Wuninitialized] pigz.c:1283:19: note: ‘temp’ was declared here cc -O3 -Wall -Wextra -c -o yarn.o yarn.c cc -O3 -Wall -Wextra -c -o zopfli/deflate.o zopfli/deflate.c cc -O3 -Wall -Wextra -c -o zopfli/blocksplitter.o zopfli/blocksplitter.c cc -O3 -Wall -Wextra -c -o zopfli/tree.o zopfli/tree.c cc -O3 -Wall -Wextra -c -o zopfli/lz77.o zopfli/lz77.c cc -O3 -Wall -Wextra -c -o zopfli/cache.o zopfli/cache.c cc -O3 -Wall -Wextra -c -o zopfli/hash.o zopfli/hash.c cc -O3 -Wall -Wextra -c -o zopfli/util.o zopfli/util.c cc -O3 -Wall -Wextra -c -o zopfli/squeeze.o zopfli/squeeze.c cc -O3 -Wall -Wextra -c -o zopfli/katajainen.o zopfli/katajainen.c cc -o pigz pigz.o yarn.o zopfli/deflate.o zopfli/blocksplitter.o zopfli/tree.o zopfli/lz77.o zopfli/cache.o zopfli/hash.o zopfli/util.o zopfli/squeeze.o zopfli/katajainen.o -lpthread -lz zopfli/tree.o: In function CalculateEntropy': tree.c:(.text+0x193): undefined reference tolog' tree.c:(.text+0x23e): undefined reference to log' tree.c:(.text+0x29b): undefined reference tolog' collect2: ld returned 1 exit status make: *\ [pigz] Error 1

[madler]

This must be relative to the master branch. This is fixed on the develop branch.

[pickupapenguin]

It is indeed master branch, apologies for the confusion !

---

From: Mark Adler notifications@github.com To: madler/pigz pigz@noreply.github.com Cc: pickupapenguin gb10hkzo-fb@yahoo.co.uk Sent: Monday, 5 August 2013, 17:52 Subject: Re: [pigz] Regression ? (re-issue #3) (#11)

This must be relative to the master branch. This is fixed on the develop branch. — Reply to this email directly or view it on GitHub.