Fixing missing dependencies in Makefile.in

madler / zlib

A massively spiffy yet delicately unobtrusive compression library.

http://zlib.net/

Other

5.58k stars 2.43k forks source link

Fixing missing dependencies in Makefile.in #1000

Closed Meiye-lj closed 1 month ago

Meiye-lj commented 1 month ago

This PR fixes an issue in the Makefile.in of zlib. Specifically, previously, any modifications of files like gzguts.h would not trigger a rebuild of zutil.o. The PR fixes this by including them as additional dependencies.

madler commented 1 month ago

Congrats on pull request #1000!

Why does this add a dependency for adler32.c?

Meiye-lj commented 1 month ago

The dependencies are added for zutil.o, so also added gzguts.h at lines 392 and 402.

madler commented 1 month ago

I see. I need to split those out. I have applied the commit locally with that update. Thanks.