search

madler / zlib

A massively spiffy yet delicately unobtrusive compression library.
http://zlib.net/
Other
5.71k stars 2.45k forks source link

configure: just warn on unknown --with/without/enable/disable option #770

Closed landfillbaby closed 9 months ago

landfillbaby commented 1 year ago

this seems to be the standard way, and makes it easier for me personally

madler commented 1 year ago

I'm missing why this is a good idea.

landfillbaby commented 1 year ago

Autoconf, for example, only warns by default. https://www.gnu.org/software/autoconf/manual/html_node/Option-Checking.html

However, by default unknown --with-package and --enable-feature options elicit only a warning, to support configuring entire source trees.

landfillbaby commented 1 year ago

... Just realised I misread that. Maybe I should change this PR to allow only unknown --with(out)-* and --(en|dis)able-*.

landfillbaby commented 1 year ago

OK now it's good unless you think that line's too long

landfillbaby commented 11 months ago

just realised i did this to master instead of develop. should i close this and open a new one?

Neustradamus commented 9 months ago

@landfillbaby: Have you progressed on it?

You can use "develop" directly.

landfillbaby commented 9 months ago

closing in favour of #912