search

madler / zlib

A massively spiffy yet delicately unobtrusive compression library.
http://zlib.net/
Other
5.58k stars 2.43k forks source link

Keep the interface stable #865

Closed speedym closed 7 months ago

speedym commented 11 months ago

Android NDK r26 is featuring clang 17 compiler, which errors out in the case when gz_intmax is mentioned in zlib.map, yet it's not part of the code base (in case INT_MAX is defined).

Also with this PR, the zlib interface becomes more stable over compiler & toolchain changes.

This is the compiler error:

ld.lld: error: version script assignment of 'local' to symbol 'gz_intmax' failed: symbol not defined
clang: error: linker command failed with exit code 1 (use -v to see invocation)

This PR is a proper fix for #856.

Neustradamus commented 10 months ago

@madler: Can you look this PR?

Neustradamus commented 9 months ago

@madler: What do you think?

madler commented 7 months ago

Apploed. Thanks.

Neustradamus commented 7 months ago

Merged commit: