search

madler / zlib

A massively spiffy yet delicately unobtrusive compression library.
http://zlib.net/
Other
5.65k stars 2.44k forks source link

Fix C++ warning 4996 #946

Closed yaqiyang closed 7 months ago

Neustradamus commented 1 month ago

@yaqiyang: Why have you closed?

madler commented 1 month ago

Just as well. These changes have nothing to do with C++, but rather with MSVC, and the changes are incompatible with other platforms. Furthermore, the warnings are addressed with the #define _CRT_SECURE_NO_WARNINGS in gzguts.h. Lastly, no description was provided for this pull request.

Do you even look at the pull requests you comment on @Neustradamus ?

Neustradamus commented 1 month ago

@madler: I have been surprised that @yaqiyang has closed 2 minutes after ^^

yaqiyang commented 1 month ago

This has been a while, and I don't remember exactly why I closed it. I think I decided to use my own fork instead.