madler / zlib

A massively spiffy yet delicately unobtrusive compression library.
http://zlib.net/
Other
5.65k stars 2.44k forks source link

change CI CMake build to use Open Watcom toolchain #955

Closed jmalak closed 2 months ago

jmalak commented 6 months ago

add __export modifier if DLL is requested to properly generate import library zlib.lib for OS/2 add CMake cross-compilation build by Open Watcom for 16/32-bit DOS and OS2, 32-bit Windows and 32-bit Linux

madler commented 6 months ago

Have you tested all of those builds you are proposing to add to cmake.yml?

jmalak commented 6 months ago

I tested build only. For Windows it is build static library and DLL and link samples with DLL and run samples. For Linux it is build static library only and link samples with static library and run samples. For DOS it is build only static library and link samples, not tested. For OS/2 it is build DLL and link samples with DLL, not tested.

You can check build and test result here

jmalak commented 6 months ago

I submit new #958 PR with OS/2 DLLbuild fix that this PR is only for CI CMake build changes

jmalak commented 6 months ago

I little reworked CI CMake actions script by using if conditions to follow existing workflow without specific actions for Watcom Now it is fully controlled by if conditions

jmalak commented 5 months ago

Pre-requisity for this change is PR "correct Open Watcom OS/2 build #958"

Neustradamus commented 2 months ago

@jmalak: Why have you closed it?

jmalak commented 2 months ago

@Neustradamus and why wouldn't I do it, they don't value voluntary contributors, they wanted it great and then they weren't even able to answer, I already wasted my time with it and it was useless, I'll go help where they value contributors

madler commented 2 months ago

@jmalak I apologize that you do not feel valued. There are too many submissions here for me to attend to all of them in a timely manner.

jmalak commented 2 months ago

Sorry, ridiculous excuses, still waiting for contributions from 2013, so maybe 10 years from now.