madler / zlib

A massively spiffy yet delicately unobtrusive compression library.
http://zlib.net/
Other
5.46k stars 2.41k forks source link

contrib/minizip: replace obsolete autotools macro AC_HELP_STRING by AS_HELP_STRING #970

Closed matlo607 closed 2 months ago

matlo607 commented 2 months ago

Description

Reference: https://www.gnu.org/software/autoconf/manual/autoconf-2.72/autoconf.html#Obsolete-Macros

The macro AC_HELP_STRING is considered obsolete and should be replaced by AS_HELP_STRING.

Current warning when running autoreconf --install --include=$(aclocal --print-ac-dir):

configure.ac:10: warning: The macro 'AC_HELP_STRING' is obsolete.
configure.ac:10: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:10: the top levelconfigure.ac:10: warning: The macro 'AC_HELP_STRING' is obsolete.
configure.ac:10: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:10: the top level

Testing

I reran autoreconf --install --include=$(aclocal --print-ac-dir) and there is no warning related AC_HELP_STRING.

libtoolize: putting auxiliary files in '.'.
libtoolize: copying file './ltmain.sh'
libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([m4])' to configure.ac,
libtoolize: and rerunning libtoolize and aclocal.
libtoolize: Consider adding '-I m4' to ACLOCAL_AMFLAGS in Makefile.am.
configure.ac:10: warning: The macro 'AC_HELP_STRING' is obsolete.
configure.ac:10: You should run autoupdate.
./lib/autoconf/general.m4:204: AC_HELP_STRING is expanded from...
configure.ac:10: the top level
configure.ac:7: installing './compile'
configure.ac:7: installing './config.guess'
configure.ac:7: installing './config.sub'
configure.ac:6: installing './install-sh'
configure.ac:6: installing './missing'
Makefile.am: installing './depcomp'

No change in the generated ./configure script.

madler commented 2 months ago

Applied. Thanks.