search

madlib-lang / madlib

Madlib language compiler
https://madlib.space
BSD 3-Clause "New" or "Revised" License
29 stars 1 forks source link

Pack all instance dicts in a struct #82

Closed aboeglin closed 1 year ago

aboeglin commented 2 years ago

Currently applyPAP handles too few args, sometimes causing it to return NULL for functions with big arities such as the ones generated when a function has many constraints, eg. derived instances for records with lots of fields.

Immediate solution will be to add more cases to applyPAP, which should be done anyways, but long term solution would be to pack all instance dictionaries in a struct as first param in order to save lots of args and making most functions use only a few args.

aboeglin commented 1 year ago

Thanks to monomorphization this is no longer needed.