search

madmalik / mononoki

a programming typeface
SIL Open Font License 1.1
4.37k stars 154 forks source link

Pipe symbol does not use full height #110

Open ebiscaia opened 1 year ago

ebiscaia commented 1 year ago

Hi,

I use doom emacs and the indent lines with the pipe symbol "|". Since the pipe symbol is not full height, the indent line has gaps which is a bit distracting. Is it possible to review the character?

Thanks,

Eduardo

madmalik commented 1 year ago

Hey! The Pipe character is mostly used as an operator, where it would look strange if it was touching the lines above and below. For your purpose, I would suggest using box drawing characters that are also in the font.

ebiscaia commented 1 year ago

Hi, further exploration made me realise I was actually meaning the drawing character you mentioned (I was using 9474 which is the decimal version of 2502). I thought that was the piping symbol (that then I found out to be even shorter) because they look very similar and the box drawing vertical bar is the default symbol of the indent line plugin. I wonder if in this case you would reconsider and alter this symbol to be full height.

Thanks again,

madmalik commented 1 year ago

Ok, thats a different matter. The box drawing character should be full height. Can you tell me which OS you're using?

ebiscaia commented 1 year ago

Fedora 38. I think I also should mention that I use the Nerd Fonts version of it.

madmalik commented 1 year ago

The box drawing characters are in fact full height. For example, on mac it looks like this:

image

I've tested under Linux and under certain sizes there seems to be a one pixel gap. There is a similar problem with the powerline symbols. I don't really know why this specific font renderer has problems with full height symbols.

One thing I can try is making those symbols oversized, so that they reach into the neighboring space. But i have to test that this doesn't create problems on other platforms.