search

madmartin / Jarolift_MQTT

Controlling Jarolift TDEF 433MHZ radio shutters via ESP8266 and CC1101 Transceiver Module in asynchronous mode
GNU General Public License v3.0
67 stars 28 forks source link

added individual positions based on time #28

Open krisha opened 4 years ago

madmartin commented 4 years ago

Hello @krisha,

good idea, I assume a lot of work, but one commit for such a huge change is way to little to merge.

Can you split it into "one commit per logical change" please?

krisha commented 4 years ago

Thank you for your reply.

Actually I think it is just one logical change. The only thing I can imagine is splitting it to 'logic', 'webserver' and 'webserver help' commits, but not sure if that makes sense.

If I split it further it will not build and/or might not work as expected on the single commits.

If I misunderstood, let me know and if possible please also attach an example.