search

madmartin / Jarolift_MQTT

Controlling Jarolift TDEF 433MHZ radio shutters via ESP8266 and CC1101 Transceiver Module in asynchronous mode
GNU General Public License v3.0
67 stars 28 forks source link

devcnt_handler without default value #6

Closed Juppit closed 6 years ago

Juppit commented 6 years ago

On Windows, I get error messages from the Arduino IDE: error: Default argument for parameter 1 of 'void devcnt_handler (boolean do_increment = true) Also by prototyping I do not succeed in solving this problem. For the few occurrences, it makes sense to work without this default value.

madmartin commented 6 years ago

Which Arduino IDE Version do you use, which ESP8266 Core Version?

Juppit commented 6 years ago

@madmartin I use Arduino 1.9.0 beta and the latest git version. The problem exists currently with Arduino 1.9.0 beta, not in 1.8.5. I use this version, because 1.8.5 allways recompiles all libraries, message: arduino build options changed rebuilding all. I wait one minute to rebuild this sketch with 1.8.5, but only 10 seconds with 1.9.0.

Furthermore, its seems to me, with arduino you never know, which bugs will be fixed in the next version or which regressions occur again.

Back to the problem, I am in favor of a change, as you know:

Be conservative in what you send, be liberal in what you accept.

madmartin commented 6 years ago

After some research, I discovered that default values for function parameters is a non-standard feature, so I agree to remove its usage here. Thanks for reporting!